Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uncloneable health analyzer text #2824

Merged

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Jan 31, 2025

About the PR

Adds text to the health analyzer informing the user when viewing an uncloneable subject.

Why / Balance

Unrevivable has this, and uncloneable's ours, so why not? More info for the doctors.

Outstanding feature TODO since the (december?) upstream merge.

How to test

  1. Give yourself the Uncloneable trait, view yourself with the health analyzer. There should be a message telling you that you're uncloneable in yellow text.
  2. Spawn a Urist, scan them with the health analyzer. No message.
  3. Give the Urist the Uncloneable trait, pop them in a cryo pod.
  4. Check the cryo pod's analyzer. No mention of it.

Media

A specimen in good health, must've gotten them out of some ice deposit or something.
image

Requirements

Breaking changes

Changelog

🆑

  • add: The health analyzer will tell you when a scanned patient is uncloneable.

@Houtblokje
Copy link
Contributor

Shouldn't the unclonable trait just be deleted? There aren't many ways to get cloning anyway, so its kinda really irrelevant.

@github-actions github-actions bot added the size/S label Feb 1, 2025
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next step is to also have a "dont borg" comp, probably can port it from DeltaV

@dvir001 dvir001 merged commit 123c630 into new-frontiers-14:master Feb 5, 2025
12 checks passed
FrontierATC added a commit that referenced this pull request Feb 5, 2025
percent-temp-percent pushed a commit to Corvax-Frontier/Frontier that referenced this pull request Feb 24, 2025
* Add uncloneable health analyzer text

* fluent: uncloneable, "cannot"->"can not"

---------

Co-authored-by: Dvir <[email protected]>
percent-temp-percent pushed a commit to Corvax-Frontier/Frontier that referenced this pull request Feb 24, 2025
percent-temp-percent pushed a commit to Corvax-Frontier/Frontier that referenced this pull request Mar 1, 2025
* Add uncloneable health analyzer text

* fluent: uncloneable, "cannot"->"can not"

---------

Co-authored-by: Dvir <[email protected]>
percent-temp-percent pushed a commit to Corvax-Frontier/Frontier that referenced this pull request Mar 1, 2025
percent-temp-percent pushed a commit to Corvax-Frontier/Frontier that referenced this pull request Mar 3, 2025
* Add uncloneable health analyzer text

* fluent: uncloneable, "cannot"->"can not"

---------

Co-authored-by: Dvir <[email protected]>
percent-temp-percent pushed a commit to Corvax-Frontier/Frontier that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants