forked from hanabi/hanabi.github.io
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newduke patch 1 #1
Open
newduke
wants to merge
556
commits into
main
Choose a base branch
from
newduke-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add question images * Add more question images * Add a couple more questions * Prettier * Fix question 7 * fixing lint * fix * fix formatting * some updates * fixes Co-authored-by: James <[email protected]>
green 4 is not playable right now
Changing Blue 5 to Yellow 5. Alternatively could add an explanation of the clues Bob's gotten on the 5s, e.g. "Bob has two unknown 5's previously clued in his hand.", but changing the color is clearer and doesn't confuse the new player. Or one could make the b5 borderless / not clued. It's easy to assume the 5s have been clued with a single 5 clue, but you can't know it for sure in the example. Prompts > finesse, so in case of just "blue" clue earlier (for some odd reason), the finesse couldn't be played like the solution suggests, as the blue unknown card would take priority.
Fix convention reasons doc link
Unnecessary moves are now level 23, so update the link back.
* Fix broken link to rules in beginner intro * Fix 30 -> 60 in prose
* Update level-16.mdx fix trivial typo * Update level-16.mdx Co-authored-by: James <[email protected]>
Fix typo
* Clarifying lvl 25 ignitions * Update level-25.mdx * Update level-25.mdx * Update level-25.mdx --------- Co-authored-by: James <[email protected]>
5 Number Ejections were added since this doc was written.
crosslink pink conventions
* Bump PyYAML to 6.0.1 * Bump other requirements to latest version
Clarify unknown trash moves
close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.