Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NR-346401 adding new confluent cloud kafka topic entity #1824

Merged
merged 21 commits into from
Jan 15, 2025

Conversation

dsankaraganti
Copy link
Contributor

@dsankaraganti dsankaraganti commented Dec 16, 2024

Relevant information

  1. Separated the telemetry data used for ConfluentCloudCluster and ConfluentCloudKafkaTopic
  2. Create a new ConfluentCloudKafkaTopic entity
  3. Modified the golden signals for ConfluentCloudCluster entity
  4. Creating a new relationship between APM entity and ConfluentCloudKafkaTopic entity

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

github-actions[bot]
github-actions bot previously approved these changes Dec 16, 2024
@dsankaraganti
Copy link
Contributor Author

I am using compositeIdentifier, name as mentioned below. Please let me know if this is correct usage

compositeIdentifier:
      separator: ":"
      attributes:
        - kafka_id
        - topic
    name: kafka.cluster_name || ":" || topic
    encodeIdentifierInGUID: true

@mborroni
Copy link
Contributor

I am using compositeIdentifier, name as mentioned below. Please let me know if this is correct usage

compositeIdentifier:
      separator: ":"
      attributes:
        - kafka_id
        - topic
    name: kafka.cluster_name || ":" || topic
    encodeIdentifierInGUID: true

name must be a single attribute, composite names are not allowed

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT sum(timeSinceBufferBegin) / sum(timeSinceLastHeartbeat) - filter(sum(timeSincePaused), where actionName = 'CONTENT_RESUME' - filter(sum(timeSinceSeekBegin), where actionName = 'CONTENT_SEEK_END')) * 100 FROM VideoAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause cannot be used to produce a valid golden metric.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT sum(timeSinceAdBufferBegin) / sum(timeSinceLastAdHeartbeat) - filter(sum(timeSinceAdPaused), where actionName = 'AD_RESUME' - filter(sum(timeSinceAdSeekBegin), where actionName = 'AD_SEEK_END')) * 100 FROM VideoAdAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause cannot be used to produce a valid golden metric.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'CONENT_ERROR' and contentPlayhead = 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_START' and contentPlayhead=0) * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'CONENT_ERROR' and contentPlayhead = 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_START' and contentPlayhead=0) * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 17, unexpected 'WHERE'

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'count(*) WHERE actionName = 'CONENT_ERROR' and contentPlayhead = 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_START' and contentPlayhead=0) * 100' - Exception: The NRQL validator was not able to parse the selection.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'AD_ERROR' and adPlayhead = 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_START' and adPlayhead = 0) * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'AD_ERROR' and adPlayhead = 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_START' and adPlayhead = 0) * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 17, unexpected 'WHERE'

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'count(*) WHERE actionName = 'AD_ERROR' and adPlayhead = 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_START' and adPlayhead = 0) * 100' - Exception: The NRQL validator was not able to parse the selection.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'CONTENT_ERROR' and contentPlayhead > 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_REQUEST') * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'CONTENT_ERROR' and contentPlayhead > 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_REQUEST') * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 17, unexpected 'WHERE'

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'count(*) WHERE actionName = 'CONTENT_ERROR' and contentPlayhead > 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_REQUEST') * 100' - Exception: The NRQL validator was not able to parse the selection.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'AD_ERROR' and adPlayhead > 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_REQUEST') * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'AD_ERROR' and adPlayhead > 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_REQUEST') * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 17, unexpected 'WHERE'

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'count(*) WHERE actionName = 'AD_ERROR' and adPlayhead > 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_REQUEST') * 100' - Exception: The NRQL validator was not able to parse the selection.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Summary metrics for key ''averageBitrateMbps': wrong golden metric reference. Couldn't find a golden metric definition with key 'averageBitrateMbps', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'averageBitrateMbps': wrong golden metric reference. Couldn't find a golden metric definition with key 'averageBitrateMbps', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Summary metrics for key ''adAverageBitrateMbps': wrong golden metric reference. Couldn't find a golden metric definition with key 'adAverageBitrateMbps', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'adAverageBitrateMbps': wrong golden metric reference. Couldn't find a golden metric definition with key 'adAverageBitrateMbps', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'INFRA-CONFLUENTCLOUDKAFKATOPIC' on synthesis - Exception: Synthesis rules match 'EXT-SERVICE' domainType with the given test data: 'MetricRaw.json file - #1' data point. Expecting synthesis rules to match 'INFRA-CONFLUENTCLOUDKAFKATOPIC'. Please review test data and synthesis rules.

* Error VALIDATING domainType: 'INFRA-CONFLUENTCLOUDKAFKATOPIC' on synthesis - Exception: Synthesis rules match 'EXT-SERVICE' domainType with the given test data: 'MetricRaw.json file - #2' data point. Expecting synthesis rules to match 'INFRA-CONFLUENTCLOUDKAFKATOPIC'. Please review test data and synthesis rules.

github-actions[bot]
github-actions bot previously approved these changes Dec 26, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 26, 2024
github-actions[bot]
github-actions bot previously approved these changes Jan 3, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 3, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 8, 2025
@otaviocarvalho otaviocarvalho requested a review from javimb January 15, 2025 09:17
@otaviocarvalho otaviocarvalho merged commit 313f78b into newrelic:main Jan 15, 2025
7 checks passed
rohit-bandlamudi-nr pushed a commit to rohit-bandlamudi-nr/entity-definitions that referenced this pull request Jan 17, 2025
…ic#1824)

* feat: Adding confluent cloud cluster entity

* feat: Adding confluent cloud cluster entity metrics

* feat: NR-258723 dashboard metric query syntax issue fix

* feat: NR-346401 adding new confluent cloud kafka topic entity

* feat: Changed folder name

* Adding  APM entity to ConfluentCloudKafkaTopic entity relationship

* Adding  APM entity to ConfluentCloudKafkaTopic entity relationship

* feat: NR-346406 adding new relationship CONFLUENTCLOUDCLUSTER MANAGES CONFLUENTCLOUDKAFKATOPIC

* feat: NR-346406 using existing category and added new lookup for kafka topic

* feat: Adding tags for confluent kafka topic

* feat: Adding test jsons

---------

Co-authored-by: Otávio Carvalho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants