Add a generic rule for APM->DB relationships #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entityBot
approved these changes
Jan 9, 2025
entityBot
approved these changes
Jan 9, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This new rule allows any hostname as DB endpoint, not limiting it to RDS. It includes a more strict regex which only includes those providers that are supported in the `DATABASE` candidate category. The regex also filters out those unsupported metric names that contain a `;` in the endpoint (legacy format to concat different endpoints in a single metric).
javimb
force-pushed
the
javimb/generic-db-rule
branch
from
20d673b to
fabfd94
Compare
entityBot
approved these changes
Jan 9, 2025
entityBot
approved these changes
Jan 9, 2025
javimb
added
do-not-merge
internal review
entityBot
approved these changes
Jan 9, 2025
entityBot
approved these changes
Jan 9, 2025
entityBot
approved these changes
Jan 9, 2025
entityBot
approved these changes
Jan 9, 2025
entityBot
approved these changes
Jan 10, 2025
entityBot
approved these changes
Jan 10, 2025
entityBot
approved these changes
Jan 10, 2025
entityBot
approved these changes
Jan 10, 2025
entityBot
approved these changes
Jan 13, 2025
entityBot
approved these changes
Jan 13, 2025
entityBot
approved these changes
Jan 13, 2025
entityBot
approved these changes
Jan 13, 2025
otaviocarvalho
approved these changes
Jan 13, 2025
entityBot
approved these changes
Jan 13, 2025
entityBot
approved these changes
Jan 13, 2025
entityBot
approved these changes
Jan 13, 2025
entityBot
approved these changes
Jan 13, 2025
rohit-bandlamudi-nr
pushed a commit
to rohit-bandlamudi-nr/entity-definitions
that referenced
this pull request
Jan 15, 2025
This new rule allows any hostname as DB endpoint, not limiting it to RDS. It includes a more strict regex which only includes those providers that are supported in the `DATABASE` candidate category. The regex also filters out those unsupported metric names that contain a `;` in the endpoint (legacy format to concat different endpoints in a single metric). Co-authored-by: Otávio Carvalho <[email protected]>
rohit-bandlamudi-nr
pushed a commit
to rohit-bandlamudi-nr/entity-definitions
that referenced
this pull request
Jan 15, 2025
This new rule allows any hostname as DB endpoint, not limiting it to RDS. It includes a more strict regex which only includes those providers that are supported in the `DATABASE` candidate category. The regex also filters out those unsupported metric names that contain a `;` in the endpoint (legacy format to concat different endpoints in a single metric). Co-authored-by: Otávio Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
This new rule allows any hostname as DB endpoint, not limiting it to RDS.
It includes a more strict regex which only includes those providers that are supported in the
DATABASEcandidate category. The regex also filters out those unsupported metric names that contain a;in the endpoint (legacy format to concat different endpoints in a single metric).This new rule, which will be internally rolled out, will eventually replace the two other rules present in the file.
Checklist
identifierwill be unique and valid.