-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the validator to ensure the uninstrumented exists #1872
Merged
apoloa
merged 4 commits into
main
from
apoloa/add_validator_for_uninstrumented_entities
Jan 21, 2025
Merged
Add the validator to ensure the uninstrumented exists #1872
apoloa
merged 4 commits into
main
from
apoloa/add_validator_for_uninstrumented_entities
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he candidate relationship is created
entityBot
approved these changes
Jan 21, 2025
entityBot
approved these changes
Jan 21, 2025
entityBot
approved these changes
Jan 21, 2025
entityBot
approved these changes
Jan 21, 2025
entityBot
approved these changes
Jan 21, 2025
entityBot
approved these changes
Jan 21, 2025
entityBot
approved these changes
Jan 21, 2025
entityBot
approved these changes
Jan 21, 2025
mborroni
approved these changes
Jan 21, 2025
bhansa-nr
pushed a commit
to bhansa-nr/entity-definitions
that referenced
this pull request
Jan 23, 2025
* Add the validator to ensure that the uninstrumented is defined when the candidate relationship is created * Add the validator in the pr validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
When the candidate relationship is created we need to ensure that the uninstrumented entity is created in order to see it in the UI.
Added a code to validate that the uninstrumented entities is created.
Checklist
identifier
will be unique and valid.