Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the validator to ensure the uninstrumented exists #1872

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

apoloa
Copy link
Contributor

@apoloa apoloa commented Jan 21, 2025

Relevant information

When the candidate relationship is created we need to ensure that the uninstrumented entity is created in order to see it in the UI.

Added a code to validate that the uninstrumented entities is created.

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

github-actions[bot]
github-actions bot previously approved these changes Jan 21, 2025
@apoloa apoloa merged commit ad5f883 into main Jan 21, 2025
6 checks passed
@apoloa apoloa deleted the apoloa/add_validator_for_uninstrumented_entities branch January 21, 2025 13:40
bhansa-nr pushed a commit to bhansa-nr/entity-definitions that referenced this pull request Jan 23, 2025
* Add the validator to ensure that the uninstrumented is defined when the candidate relationship is created

* Add the validator in the pr validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants