Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ibm iseries #1895

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add ibm iseries #1895

wants to merge 3 commits into from

Conversation

LouwMarais
Copy link

Relevant information

Added a new External IBM iSeries entity definition with the main goal being that our custom insights metric generated with an attribute of includeInIseriesEntity should be used to automatically create our IBM iSeries as an Entity and visible on distributed tracing maps

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

@LouwMarais LouwMarais mentioned this pull request Feb 3, 2025
3 tasks

synthesis:
name: hostName
identifier: hostName
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is too broad and will match any datapoints for all customers of the company that include a hostName. Could you please share the use case and metric with us on the #help-relationship-platform internal channel?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I hoped that the condition that I add an attribute of "includeInIseriesEntity" with any value in a log/custom metric would be the only time that the entity would be used. This is an example of how we would send an event to tag to this entity

curl --location 'https://insights-collector.newrelic.com/v1/accounts/<accountIdHere>/events' \ --header 'Content-Type: application/json' \ --header 'X-Insert-Key: <customInsgihtKeyHere> \ --data '{ "eventType": "MyCustomInsightEvent", "hostName": "MyUniqueHostname", "includeInIseriesEntity" : "*YES", "systemName": "MyUniqueSystemName", "ipAddress": "10.11.12.13", "otherAttribute1": "otherValue1", "otherAttribute2": "otherValue2" }'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume '#help-relationship-platform' is a slack channel, if you can also let me know how to get invited to that happy to chat more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@otaviocarvalho let me know how I can get in touch with you if need to discuss this one more or for further advice. I am not sure how to remove the label after providing the feedback.
Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants