Update locales to include french #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for newrelic-gatbsy-theme-demo canceled.
|
| @@ -38,6 +38,13 @@ const LOCALE_CONFIGS = { | |||
| hrefLang: 'pt', | |||
| isDefault: false, | |||
| }, | |||
| fr: { | |||
There was a problem hiding this comment.
Do we need to add 'fr' here as well?
There was a problem hiding this comment.
💀 yep definitely. without it it won't pick up the french json we use for a lot of our components but i didn't test that because we don't have any json in french yet, whoops
sunnyzanchi
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉