Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[agent-control] update system identity creation query #1587

Merged
merged 3 commits into from
Feb 17, 2025
Merged

[agent-control] update system identity creation query #1587

merged 3 commits into from
Feb 17, 2025

Conversation

sigilioso
Copy link
Contributor

@sigilioso sigilioso commented Jan 28, 2025 •
edited
Loading

This PR updates the L2 identity creation endpoints and query

Special notes for your reviewer:

We'll keep it as a draft until the whole flow is validated (done)

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

@sigilioso sigilioso force-pushed the feat/agent-control/update-system-identity-query branch from cd3e496 to 8749f59 Compare February 10, 2025 15:24
rubenruizdegauna
rubenruizdegauna previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

@sigilioso sigilioso force-pushed the feat/agent-control/update-system-identity-query branch from 8749f59 to 60dbcb4 Compare February 13, 2025 07:13
paologallinaharbur
paologallinaharbur previously approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@paologallinaharbur paologallinaharbur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! 😄

you need a dependency update 🤔

@sigilioso sigilioso force-pushed the feat/agent-control/update-system-identity-query branch from 50d8c36 to c5ead08 Compare February 17, 2025 07:36
@sigilioso sigilioso marked this pull request as ready for review February 17, 2025 07:36
@sigilioso sigilioso requested review from a team as code owners February 17, 2025 07:36
@sigilioso sigilioso changed the title [agent-control] update system identity creation query [WIP] [agent-control] update system identity creation query Feb 17, 2025
sigilioso and others added 3 commits February 17, 2025 08:56
@sigilioso
chore(agent-control): update system identity creation query and endpo…
52289b2 
…ints
@mraju1 @sigilioso
Fixes
cc8a06b 
- look for new systemIdentityCreate to get CLIENT_ID
- update right urls for regions
@sigilioso
chore: bump chart version
247752a
@sigilioso sigilioso force-pushed the feat/agent-control/update-system-identity-query branch from c5ead08 to 247752a Compare February 17, 2025 07:56
@sigilioso sigilioso mentioned this pull request Feb 17, 2025
Merged
@sigilioso sigilioso merged commit 36a8f5b into master Feb 17, 2025
11 checks passed
@sigilioso sigilioso deleted the feat/agent-control/update-system-identity-query branch February 17, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paologallinaharbur paologallinaharbur paologallinaharbur approved these changes

@rubenruizdegauna rubenruizdegauna Awaiting requested review from rubenruizdegauna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sigilioso @rubenruizdegauna @paologallinaharbur @mraju1