Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent-control] fix: Added backofflimit and ignore-not-found to the uninstall-job #1617

Merged
merged 1 commit into from
Feb 17, 2025
Merged

[agent-control] fix: Added backofflimit and ignore-not-found to the uninstall-job #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/agent-control/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ dependencies:
version: 2.14.1
- name: agent-control-deployment
repository: ""
version: 0.0.39-beta
version: 0.0.40-beta
- name: common-library
repository: https://helm-charts.newrelic.com
version: 1.3.1
digest: sha256:9f32bf1c7e1c5e5fe4bf0ca1d48ee89155816667971393d7d9ad147dc8bb7768
generated: "2025-02-17T08:34:45.995478+01:00"
digest: sha256:81728940ef40bb132f63a5beb9f419397a370191fdd3025332bf819c2159443c
generated: "2025-02-17T10:50:05.543595+01:00"
4 changes: 2 additions & 2 deletions charts/agent-control/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ name: agent-control
description: Bootstraps New Relic' Agent Control

type: application
version: 0.0.48-beta
version: 0.0.49-beta

dependencies:
- name: flux2
repository: https://fluxcd-community.github.io/helm-charts
version: 2.14.1
condition: flux2.enabled
- name: agent-control-deployment
version: 0.0.39-beta
version: 0.0.40-beta
condition: agent-control-deployment.enabled
# The following dependency is needed as sub-dependency of agent-control-deployment
- name: common-library
Expand Down
2 changes: 1 addition & 1 deletion charts/agent-control/charts/agent-control-deployment/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Helm chart to install New Relic Agent Control on Kubernetes

type: application

version: 0.0.39-beta
version: 0.0.40-beta

keywords:
- newrelic
Expand Down
2 changes: 1 addition & 1 deletion ...ol/charts/agent-control-deployment/templates/preinstall-job-register-system-identity.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ spec:
{{ include "newrelic-agent-control.auth.secret.name" . }} \
--from-literal=CLIENT_ID=$CLIENT_ID \
--from-file="private_key=$TEMPORAL_FOLDER/key" | \
jq '.metadata.labels |= {{ include "newrelic.common.labels" . | fromYaml | toJson }}' | \
jq '.metadata.labels += ({{ include "newrelic.common.labels" . | fromYaml | toJson }} + {"nr-generic-secret": "true"})' | \
kubectl apply -n "{{ .Release.Namespace }}" -f -
---
{{ if .Values.rbac.create }}
Expand Down
3 changes: 2 additions & 1 deletion charts/agent-control/charts/agent-control-deployment/templates/uninstall-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ metadata:
namespace: {{ .Release.Namespace }}
spec:
ttlSecondsAfterFinished: 120
backoffLimit: 3
template:
spec:
restartPolicy: Never
Expand Down Expand Up @@ -49,6 +50,6 @@ spec:

{{- if include "newrelic-agent-control.auth.secret.shouldRunJob" . }}
# Delete the secrets created in the cluster
kubectl -n {{ $.Release.Namespace }} delete secret {{ include "newrelic-agent-control.auth.secret.name" . }}
kubectl delete secrets -n {{ .Release.Namespace }} -l "nr-generic-secret=true"
{{- end }}
{{- end -}}
Loading