Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dimensions should be type: string, number or boolean #255

Open
varas opened this issue Jan 15, 2021 · 0 comments
Open

Dimensions should be type: string, number or boolean #255

varas opened this issue Jan 15, 2021 · 0 comments
Labels
bug Categorizes issue or PR as related to a bug. triage/pending Issue or PR is pending for triage and prioritization.

Comments

@varas
Copy link
Contributor

varas commented Jan 15, 2021

Description

According to documentation a dimension/attribute might be a string, number or boolean.

A map of key value pairs associated with this specific metric. Values can be strings, JSON numbers, or booleans. Keys are case-sensitive and must be less than 255 characters.

But we just support string ones https://github.com/newrelic/infra-integrations-sdk/blob/master/data/metric/metrics.go#L19

Expected Behavior

Change metric.Dimensions type.
@varas varas added the bug Categorizes issue or PR as related to a bug. label Jan 15, 2021
@varas varas mentioned this issue Jan 15, 2021
Merged
@davidgit davidgit added the triage/pending Issue or PR is pending for triage and prioritization. label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug. triage/pending Issue or PR is pending for triage and prioritization.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidgit @varas