Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: entity common dimensions support #254

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

varas
Copy link
Contributor

@varas varas commented Jan 15, 2021

Adding support for entity "common" dimensions. These ones are applied to every entity metric at platform level.

I'm not adding documentation for "common dimensions" as we need to fix what a dimension is.

Fixes #250

@varas varas requested a review from a team January 15, 2021 14:41
@varas varas added the risk:low label Jan 15, 2021
Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@varas varas merged commit 1601955 into master Jan 15, 2021
@varas varas deleted the feat_entity-common-dimenensions branch January 15, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setters and document the "common" attribute
2 participants