Skip to content

Commit

Permalink
Merge pull request #22 from newrelic/missing-metrics
Browse files Browse the repository at this point in the history
Missing metrics
  • Loading branch information
Corbin Phelps authored Aug 22, 2018
2 parents 846596a + d6f6cdb commit 7eba8be
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/metrics/broker_definitions.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ var brokerMetricDefs = []*JMXMetricSet{
MetricPrefix: "kafka.network:type=RequestMetrics,name=TotalTimeMs,request=Offsets,",
MetricDefs: []*MetricDefinition{
{
Name: "request.avgTimeUpdateMetadata",
Name: "request.avgTimeOffset",
SourceType: metric.GAUGE,
JMXAttr: "attr=Mean",
},
{
Name: "request.avgTimeUpdateMetadata99Percentile",
Name: "request.avgTimeOffset99Percentile",
SourceType: metric.GAUGE,
JMXAttr: "attr=99thPercentile",
},
Expand Down
10 changes: 10 additions & 0 deletions src/metrics/producer_definitions.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ var producerMetricDefs = []*JMXMetricSet{
SourceType: metric.GAUGE,
JMXAttr: "client-id=" + producerHolder + ",attr=request-size-max",
},
{
Name: "producer.avgRecordAccumulatorsInMilliseconds",
SourceType: metric.GAUGE,
JMXAttr: "client-id=" + producerHolder + ",attr=record-queue-time-avg",
},
},
},
{
Expand Down Expand Up @@ -147,6 +152,11 @@ var ProducerTopicMetricDefs = []*JMXMetricSet{
SourceType: metric.GAUGE,
JMXAttr: "attr=record-send-rate",
},
{
Name: "producer.avgCompressionRateRecordBatches",
SourceType: metric.GAUGE,
JMXAttr: "attr=compression-rate",
},
},
},
}
Expand Down

0 comments on commit 7eba8be

Please sign in to comment.