Step1 - 문자열 덧셈 계산기 #815
Merged
Step1 - 문자열 덧셈 계산기 #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
이전 커밋 이력과 함께 미션이 수행되었네요. 미션 수행을 위한 STEP을 확인해서 진행하시면 좋을 것 같아요~! 😄 |
sihoony
requested changes
Jan 31, 2025
| String delimiter = "[,:]"; | ||
| String numbers = text; | ||
|
|
||
| Matcher matcher = Pattern.compile("//(.)\n(.*)").matcher(text); |
There was a problem hiding this comment.
Pattern을 캐싱해보면 어떨까요?
고정적이면서 생성 비용이 많이 드는 항목은 사전에 생성해둔다면 성능상 이점을 가져갈 수 있겠네요~! 😄
Comment on lines
26
to
28
| if (number < 0) { | ||
| throw new RuntimeException("Negative numbers are not allowed: " + number); | ||
| } |
There was a problem hiding this comment.
0 미만에 대한 책임을 분리하기 위하여 VO를 활용해보면 어떨까요?
|
|
||
| return sum; | ||
| } | ||
| } |
There was a problem hiding this comment.
마지막은 개행으로 끝날 수 있도록 설정해보면 어떨까요~!?
reversalSpring
force-pushed
the
step1-1
branch
from
4d5f0a3 to
bd262f8
Compare
sihoony
requested changes
Feb 3, 2025
| assertThatExceptionOfType(RuntimeException.class) | ||
| .isThrownBy(() -> calculator.add("-1")); | ||
| } | ||
| } |
Comment on lines
27
to
30
| int number = Integer.parseInt(token); | ||
| if (number < 0) { | ||
| throw new RuntimeException("Negative numbers are not allowed: " + number); | ||
| } |
There was a problem hiding this comment.
Number라는 VO를 통해서 숫자를 관리해보면 어떨까요~!?
궁금하신 점은 DM으로 남겨주셔도 됩니다~! 😄
sihoony
requested changes
Feb 4, 2025
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType; | ||
|
|
||
| class StringCalculatorTest { |
There was a problem hiding this comment.
Number에 대한 TestCode를 분리해서 만들어보면 어떨까요~!? 😄
| @@ -0,0 +1,16 @@ | |||
| package StringCalculator; | |||
|
|
|||
| public class Number { | |||
Comment on lines
24
to
31
| String[] tokens = numbers.split(delimiter); | ||
| int sum = 0; | ||
| for (String token : tokens) { | ||
| Number number = new Number(token); | ||
| sum += number.getValue(); | ||
| } | ||
|
|
||
| return sum; |
There was a problem hiding this comment.
일급컬렉션을 활용하여 작성해보면 어떨까요~!?
합산에 대한 책임 명확하게 분리될 것 같아요~!
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
sihoony
approved these changes
Feb 7, 2025
| assertThatExceptionOfType(RuntimeException.class) | ||
| .isThrownBy(() -> new Number("-1")); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit 5 학습 을 step 1 으로 브런치를 따서 이번 문자열 덧셈 계산기를 1-1로 만들어 푸시했습니다.
문자열 덧셈 계산기를 만들었습니다. 리뷰 부탁 드립니다.