Step 3 : 테스트를 통한 코드 보호 #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihoony
requested changes
Feb 6, 2025
| import kitchenpos.infra.client.PurgomalumClient; | ||
| import org.springframework.boot.web.client.RestTemplateBuilder; | ||
|
|
||
| public class FakePurgomalumClient extends PurgomalumClient { |
| import kitchenpos.domain.MenuGroup; | ||
| import kitchenpos.domain.MenuProduct; | ||
|
|
||
| public class MenuFixture { |
|
|
||
| public class FakeMenuGroupRepository implements MenuGroupRepository { | ||
|
|
||
| private final Map<UUID, MenuGroup> dataMap = new ConcurrentHashMap<>(); |
| .extracting(MenuGroup::getName) | ||
| .containsExactlyInAnyOrder(names.toArray(String[]::new)); | ||
| } | ||
| } |
There was a problem hiding this comment.
마지막은 개행으로 끝날 수 있도록 설정해보면 어떨까요~!?
| import org.springframework.boot.web.client.RestTemplateBuilder; | ||
| import org.springframework.data.util.Pair; | ||
|
|
||
| class ProductServiceTest { |
There was a problem hiding this comment.
요구사항 중 이름은 필수 입력 값이며, 비속어를 사용할 수 없다. 항목에 대해서 이름이 필수다를 검증해보면 어떨까요?
There was a problem hiding this comment.
(테스트 케이스 추가)
|
|
||
| @DisplayName("배달 주문을 생성할 수 있다.") | ||
| @Test | ||
| void createDelivery() { |
There was a problem hiding this comment.
(주문 상태가 WAITING인지 검증 추가)
sihoony
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리베이스를 잘못하여 step2 커밋이 섞었습니다😂
test: 메뉴그룹 리팩토링, 테스트 코드 작성커밋부터 리뷰 부탁드립니다.언제나 감사합니다.🙇♂️