1단계 - 문자열 계산기 구현 #836
Open
1단계 - 문자열 계산기 구현 #836
+145
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunssooo
requested changes
Feb 5, 2025
Comment on lines
+5
to
+7
|
|
||
| public class Delimiters { | ||
| private final Set<String> delimiters; |
There was a problem hiding this comment.
Delimiters 일급컬렉션 👍
Delimiter 자체도 포장해 볼 수 있지 않을까요?
Comment on lines
+19
to
+24
| public String[] split(String text) { | ||
| for (String delimiter : delimiters) { | ||
| text = text.replace(delimiter, " "); | ||
| } | ||
| return text.split(" "); | ||
| } |
There was a problem hiding this comment.
parameter 값을 재할당해 사용하고 있네요. 현재는 코드가 복잡하지 않아 괜찮지만 코드가 복잡해지면 디버깅이 힘들 것 같습니다.
이를 방지하기 위해 final 키워드를 사용해 보는 것도 좋을 것 같습니다. :)
Comment on lines
+8
to
+10
| if (number < 0) { | ||
| throw new RuntimeException("Negative numbers are not allowed: " + number); | ||
| } |
Comment on lines
+32
to
+40
| private int sumTokens(String[] tokens) { | ||
| int sum = 0; | ||
| for (String token : tokens) { | ||
| if (!token.isEmpty()) { | ||
| sum += NumberParser.parse(token); | ||
| } | ||
| } | ||
| return sum; | ||
| } |
There was a problem hiding this comment.
규칙 1: 한 메서드에 오직 한 단계의 들여쓰기만 한다.
를 지켜보는 것은 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
감사합니다