step1. test 통과 #837
Open
step1. test 통과 #837
+109
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlroh
requested changes
Feb 5, 2025
Comment on lines
+8
to
+9
| public StringCalculator() { | ||
| } |
| } | ||
|
|
||
| Matcher matcher = Pattern.compile("//(.)\n(.*)").matcher(text); | ||
| String separator = ",|:"; // 기본 구분자 |
| return 0; | ||
| } | ||
|
|
||
| Matcher matcher = Pattern.compile("//(.)\n(.*)").matcher(text); |
There was a problem hiding this comment.
정규식을 다루는 Pattern 은 생성비용이 매우 비싸요. 😢
매번 생성하는 것보다 재활용을 해보는 것은 어떨까요?
Comment on lines
+21
to
+22
| separator = Pattern.quote(matcher.group(1)); | ||
| text = matcher.group(2); |
There was a problem hiding this comment.
1,2 또한 비즈니스적으로 의미가 있는 것으로 보여요.
여기도 의미를 부여해보면 어떨까요?
| @ParameterizedTest | ||
| @ValueSource(strings = {"1"}) | ||
| void oneNumber(final String text) { | ||
| assertThat(calculator.add(text)).isSameAs(Integer.parseInt(text)); |
There was a problem hiding this comment.
저는 테스트코드에서 검증할때 하드코딩을 선호해요.
아래 링크도 참고해보시면 좋을 것 같아요.
https://jojoldu.tistory.com/615
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class StringCalculator { |
There was a problem hiding this comment.
현재 StringCalculator 가 매우 많은 역할을 하고 있는 것으로 보여져요. 😢
클래스를 분리해서 각각 객체간의 역함을 위임하여 객체간의 협력으로 문제를 풀어보면 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 !
너무 늦었네요,, 잘 부탁드립니다 !