Improve retry failed uploads function #12911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Mayer <[email protected]>
Signed-off-by: Jonas Mayer <[email protected]>
# Conflicts: # app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt
alperozturk96
approved these changes
Apr 24, 2024
Signed-off-by: Jonas Mayer <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12911.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple optimization to the retry Uploads function.
The main improvement is to not restart the worker for every upload, but just update the database and in the end restart the upload worker for each account once.
Should solve some inconsistencies in the upload tab when handling a lot of files (around 7000).