feat: save default target language & set detect_language as origin default #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
requested changes
Jan 7, 2025
| }) | ||
| this.taskTypes = taskTypes | ||
|
|
||
| this.getLastTargetLanguage() |
There was a problem hiding this comment.
It would probably work to call this asynchronously and change the task type (in this.taskTypes) once you get the answer.
It would mean keeping the previous code (taskTypes.forEach and then this.taskTypes = taskTypes) and then doing the this.getLastTargetLanguage().then(r => // find and change the task type in this.taskTypes)
This would solve the delay issue as the taskTypes data prop would be set as soon as possible. It would not be slowed down by this.getLastTargetLanguage().
…default Signed-off-by: Jana Peper <[email protected]>
…the standalone page Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
feat/set-language-defaults
branch
from
305e12e to
8d2c550
Compare
julien-nc
approved these changes
Jan 8, 2025
marcelklehr
approved these changes
Jan 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a short loading time before task types will be shown in the assistant modal. Ideas how to prevent that very welcome :)