Improve media download and preview endpoints #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julien-nc
commented
Jan 27, 2025
julien-nc
commented
- Use new endpoint to download task output files. This one deduces the mimetype from the file content. (So browsers append a type extension to the file name when downloading)
- Cache download and preview endpoint responses
- Use the preview endpoint to display result images (300x300) instead of getting the complete image
- Generate openapi specs
- Fix psalm issues
…e detection, use preview endpoint to display image results Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/media-mimetype-endpoints
branch
from
2c58536 to
6cad0c5
Compare
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/media-mimetype-endpoints
branch
from
6cad0c5 to
a19dbe0
Compare
marcelklehr
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.