Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suggest props that are not compatible with the version of the vcard #631

Open
skjnldsv opened this issue Sep 18, 2018 · 4 comments
Open
Labels
1. to develop Accepted and waiting to be taken care of medium Medium priority

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Sep 18, 2018

On the add new property, we should not allow the addition of properties that are not allowed on the vcard rfc.

There is an issue regarding the allowed data on the ical.js: kewisch/ical.js#363

https://github.com/mozilla-comm/ical.js/blob/d26b19fa5adb4d3d6e03bff6c6e4c0705c12ab11/lib/ical/design.js#L873


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of medium Medium priority vue labels Sep 18, 2018
@skjnldsv skjnldsv added this to the 3.1.0 milestone Sep 18, 2018
@nextcloud nextcloud deleted a comment from nextcloud-bot Sep 18, 2018
@skjnldsv skjnldsv removed the vue label Oct 28, 2018
@skjnldsv skjnldsv changed the title [Vue] Do not suggest props that are not compatible with the version of the vcard Do not suggest props that are not compatible with the version of the vcard Oct 28, 2018
@spoorun
Copy link

spoorun commented Apr 8, 2019

The issue here one can see is that when a User creates a new contact through the app, it appears to be automatically created as vCard 3 rather than vCard 4, with no option to force vCard 4.
For those Users wishing to sync with vCard 4 services, this is problematic.

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 9, 2019

@olantrust We're creating vcard4 by default :)

async newContact() {
const rev = new VCardTime()
const contact = new Contact(`
BEGIN:VCARD
VERSION:4.0
PRODID:-//Nextcloud Contacts v${appVersion}
END:VCARD
`.trim().replace(/\t/gm, ''),
this.defaultAddressbook)

@spoorun
Copy link

spoorun commented Apr 9, 2019

@olantrust We're creating vcard4 by default :)

contacts/src/views/Contacts.vue

Lines 310 to 318 in 6a9025c
async newContact() {
const rev = new VCardTime()
const contact = new Contact( BEGIN:VCARD VERSION:4.0 PRODID:-//Nextcloud Contacts v${appVersion} END:VCARD .trim().replace(/\t/gm, ''),
this.defaultAddressbook)

OK, just each card that I download from new contacts created in Contacts App v 3.10 are specified as VCARD Version 3.0.

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 9, 2019

@olantrust this is a server issue I guess then! 🤔
EDIT: #4038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of medium Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants