Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove documentation for user_external #11828

Merged
merged 1 commit into from
May 17, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented May 16, 2024

☑️ Resolves

Users expect, because the app is mentioned in our admin documentation, that there should be a compatible release and are disappointed if not.

We do not maintain or support user_external, and therefore the mention in our documention should go.

🖼️ Screenshots

Users expect, because the app is mentioned in our admin documentation, that there should be a compatible release and are disappointed if not.

We do not maintain or support user_external, and therefore the mention in our documention should go.

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb self-assigned this May 16, 2024
@kesselb kesselb added this to the Nextcloud 30 milestone May 16, 2024
@joshtrichards
Copy link
Member

joshtrichards commented May 16, 2024

Woah, this goes way back. It's been around forever. (EDIT: to clarify: the "woah" was a reaction to seeing the age of the original addition; not about removing it).

I'm okay with this, though it brings up a larger discussion of whether it's okay to mention things like this in the docs but somehow make it clearer they're community apps/not fully supported/etc. Sometimes we're going to want to do this I imagine.

That said, the focus of the Admin Manual should be on shipped plus... featured?I guess.

@joshtrichards
Copy link
Member

Backports desired?

@joshtrichards
Copy link
Member

/backport to stable29

@joshtrichards
Copy link
Member

/backport to stable28

@joshtrichards
Copy link
Member

/backport to stable27

@kesselb
Copy link
Contributor Author

kesselb commented May 16, 2024

I'm okay with this, though it brings up a larger discussion of whether it's okay to mention things like this in the docs but somehow make it clearer they're community apps/not fully supported/etc. Sometimes we're going to want to do this I imagine.

True.

I guess it's okay and also wanted to have hints about apps in our documentation, but those apps should be maintained and not abandoned. ;)

As reference:
https://help.nextcloud.com/t/external-user-authentication-not-compatible-with-nextcloud-28/185718
nextcloud/user_external#246

@blizzz blizzz merged commit 95b2baa into master May 17, 2024
11 checks passed
@blizzz blizzz deleted the enh/noid/remove-user-auth-external branch May 17, 2024 12:42
@violoncelloCH
Copy link
Member

I'm okay with this, though it brings up a larger discussion of whether it's okay to mention things like this in the docs but somehow make it clearer they're community apps/not fully supported/etc. Sometimes we're going to want to do this I imagine.

I think the thing here is that user_external was once created by a core dev and was part of a repo with multiple apps which were (I think) shipped with Nextcloud. That bundled repo was then abandoned and not integrated any more. Then user_external was split out of this and I'm since trying to maintain it in my free time. However my workload for university is currently so high that I don't find time to properly test and feel confident about creating releases for this app, sorry :/

@kesselb
Copy link
Contributor Author

kesselb commented May 20, 2024

Thanks @violoncelloCH, for the update and maintaining user_external 👍

I think it's fine and understandable that university is your top priority.

@Aaron-Ritter
Copy link

@kesselb Is this something which should get back added in to the core, or maybe at least parts of it?

Especially things like IMAP, HTTP BasicAuth and SSH which is very close to the functionality of nextcloud.

  1. IMAP (email) is often defined for each nextcloud user anyway, and using the same login for email and nextcloud is therefore closely connected.
  2. HTTP BasicAuth is especially in simple nextcloud setups always a topic
  3. SSH especially when you already have a system setup with multiple ssh users on the same system as nextcloud.

Maybe the IMAP part could be integrated back in to nextcloud with the email overhaul?

@kesselb
Copy link
Contributor Author

kesselb commented Jun 2, 2024

I don't think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants