Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typo broke background sync #2470

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

toad
Copy link

@toad toad commented Dec 17, 2024

#2408 and #2424 do not work because of a typo (wrong null coalescing operator). So on our existing installation, we get an undefined array key error here. Note that this is actually @Koc 's fix.

@toad toad force-pushed the background-sync-2408-typo-fix branch from 452fdac to d5e3a9f Compare December 17, 2024 21:14
So on our existing installation, we get an undefined array key error here.

Signed-off-by: Matthew Toseland <[email protected]>
@toad toad force-pushed the background-sync-2408-typo-fix branch from d5e3a9f to f15d735 Compare December 17, 2024 21:21
@toad toad marked this pull request as draft December 17, 2024 21:27
@toad
Copy link
Author

toad commented Dec 17, 2024

@Koc I created a pull request as you suggested. I guess since this passed tests when you committed it it needs more?

@Chartman123 Chartman123 requested review from Koc and AIlkiv December 18, 2024 07:36
@Chartman123 Chartman123 added bug Something isn't working 3. to review Waiting for reviews labels Dec 18, 2024
@Chartman123 Chartman123 added this to the 4.3.5 milestone Dec 18, 2024
@Chartman123 Chartman123 marked this pull request as ready for review December 18, 2024 07:37
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.27%. Comparing base (af92fa4) to head (f15d735).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2470   +/-   ##
=========================================
  Coverage     44.27%   44.27%           
+ Complexity      860      859    -1     
=========================================
  Files            73       73           
  Lines          3268     3268           
=========================================
  Hits           1447     1447           
  Misses         1821     1821           

@Chartman123
Copy link
Collaborator

/backport to stable4

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Dec 18, 2024
@Chartman123 Chartman123 merged commit 1f9b604 into nextcloud:main Dec 18, 2024
53 of 54 checks passed
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Dec 18, 2024
Copy link

github-actions bot commented Jan 1, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants