-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Typo broke background sync #2470
Fix: Typo broke background sync #2470
Conversation
452fdac
to
d5e3a9f
Compare
So on our existing installation, we get an undefined array key error here. Signed-off-by: Matthew Toseland <[email protected]>
d5e3a9f
to
f15d735
Compare
@Koc I created a pull request as you suggested. I guess since this passed tests when you committed it it needs more? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
=========================================
Coverage 44.27% 44.27%
+ Complexity 860 859 -1
=========================================
Files 73 73
Lines 3268 3268
=========================================
Hits 1447 1447
Misses 1821 1821 |
/backport to stable4 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
#2408 and #2424 do not work because of a typo (wrong null coalescing operator). So on our existing installation, we get an undefined array key error here. Note that this is actually @Koc 's fix.