[WP#57970]Add warning when encryption for group folders are not enabled explicitly #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagarGi
changed the title
SagarGi
force-pushed
the
add/warnForGroupFolderEncryption
branch
5 times, most recently
from
c096a47
to
c1d0cc6
Compare
SagarGi
force-pushed
the
add/warnForGroupFolderEncryption
branch
3 times, most recently
from
fccff3b
to
3dcc563
Compare
individual-it
requested changes
Oct 18, 2024
src/components/AdminSettings.vue
Outdated
| @@ -182,6 +182,7 @@ | |||
| :title="t('integration_openproject', 'Project folders (recommended)')" | |||
| :is-setup-complete-without-project-folders="isSetupCompleteWithoutProjectFolders" | |||
| :is-there-error-after-project-folder-and-app-password-setup="isThereErrorAfterProjectFolderAndAppPasswordSetup" | |||
| :is-there-group-folders-encryption-warning="showEncryptionWarningForGroupFolders" | |||
There was a problem hiding this comment.
any reason the names don't match each other?
There was a problem hiding this comment.
Yes it can be changed according to the function name. show-encryption-warning-for-groupfolders
src/components/AdminSettings.vue
Outdated
| @@ -265,6 +266,12 @@ | |||
| </p> | |||
| <p class="note-card--error-description" v-html="projectFolderSetUpErrorMessageDescription(state.project_folder_info.errorMessage)" /> <!-- eslint-disable-line vue/no-v-html --> | |||
| </NcNoteCard> | |||
| <NcNoteCard v-else-if="showEncryptionWarningForGroupFolders" class="note-card" type="warning"> | |||
| <p class="note-card--title"> | |||
| <b>{{ t('integration_openproject', 'Encryption for Group Folders are not enabled.') }}</b> | |||
There was a problem hiding this comment.
Suggested change
| <b>{{ t('integration_openproject', 'Encryption for Group Folders are not enabled.') }}</b> | |
| <b>{{ t('integration_openproject', 'Encryption for the Group Folders App is not enabled.') }}</b> |
src/components/AdminSettings.vue
Outdated
| <p class="note-card--title"> | ||
| <b>{{ t('integration_openproject', 'Encryption for Group Folders are not enabled.') }}</b> | ||
| </p> | ||
| <p class="note-card--warning-description" v-html="getGroupFolderEncryptionWarningHint" /> <!-- eslint-disable-line vue/no-v-html --> |
There was a problem hiding this comment.
Suggested change
| <p class="note-card--warning-description" v-html="getGroupFolderEncryptionWarningHint" /> <!-- eslint-disable-line vue/no-v-html --> | |
| <p class="note-card--warning-description" v-html="getGroupFoldersEncryptionWarningHint" /> <!-- eslint-disable-line vue/no-v-html --> |
be consequent with singular/plural
src/components/AdminSettings.vue
Outdated
| getGroupFolderEncryptionWarningHint() { | ||
| const linkText = t('integration_openproject', 'documentation') | ||
| const htmlLink = `<a class="link" href="https://www.openproject.org/docs/system-admin-guide/integrations/nextcloud/#files-are-not-encrypted-when-using-nextcloud-server-side-encryption" target="_blank" title="${linkText}">${linkText}</a>` | ||
| return t('integration_openproject', 'Server-side encryption is active, but encryption for group folders is not yet enabled. To ensure secure storage of files in project folders, please follow the configuration steps in the {htmlLink}.', { htmlLink }, null, { escape: false, sanitize: false }) |
There was a problem hiding this comment.
here group folders is written in lower case, please be consequent when referring to the Group Folders App
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Sagar <[email protected]>
Signed-off-by: Sagar <[email protected]>
Signed-off-by: Sagar <[email protected]>
Signed-off-by: Sagar <[email protected]>
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
add/warnForGroupFolderEncryption
branch
from
49d3d38
to
d5d24db
Compare
PHP Code CoverageCoverage after merging add/warnForGroupFolderEncryption into release/2.7 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile