Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mention to mail #10122

Merged
merged 1 commit into from
Oct 7, 2024
Merged

feat: add mention to mail #10122

merged 1 commit into from
Oct 7, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Sep 9, 2024

fix #10110

Screen.Recording.2024-09-19.at.15.23.34.mov

@hamza221 hamza221 self-assigned this Sep 9, 2024
@hamza221 hamza221 marked this pull request as ready for review September 9, 2024 15:41
@hamza221 hamza221 marked this pull request as draft September 12, 2024 12:26
@hamza221 hamza221 marked this pull request as ready for review September 19, 2024 13:22
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb feature!

Works well! I only noticed a few minor issues

  • There are XHR requests to search for empty names
  • There is an XHR request to search once the mention suggestion is selected with tab/enter

Nice to have

  • Avoid searching the same term again. Cache the responses.

@hamza221
Copy link
Contributor Author

hamza221 commented Oct 3, 2024

@ChristophWurst

There is an XHR request to search once the mention suggestion is selected with tab/enter

Unfortunately that can't / will be hard to fix since that's how the mention plugin work in CKEditor (a feature not a bug)
since the trigger '@' here is kept unlike for (links and emojis)
anytime you have your cursor near a trigger it will call the search function to update the state

@ChristophWurst
Copy link
Member

Fair, but we can just not do a request for an empty string ;-)

@hamza221
Copy link
Contributor Author

hamza221 commented Oct 3, 2024

Fair, but we can just not do a request for an empty string ;-)

yes that's fixed

Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221 hamza221 merged commit e55547c into main Oct 7, 2024
35 checks passed
@hamza221 hamza221 deleted the feat/mention branch October 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add recipients to a message using the @ symbol
2 participants