Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter messages by mention #10243

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat: filter messages by mention #10243

merged 1 commit into from
Oct 15, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Oct 9, 2024 •
edited
Loading

fix #10112

@hamza221 hamza221 changed the title feat: fiter messages by mention feat: filter messages by mention Oct 10, 2024
@hamza221 hamza221 force-pushed the deat/filter-mention branch 2 times, most recently from 5c9a489 to f46ed57 Compare October 10, 2024 14:39
@hamza221
Copy link
Contributor Author

hamza221 commented Oct 10, 2024 •
edited
Loading

Works for now but only new messages can be filtered, it's okay I think since the feature was just merged.
A resync of the whole account would work too
Pr still needs a little cleanup and frontend is missing

@hamza221 hamza221 marked this pull request as ready for review October 10, 2024 17:05
ChristophWurst
ChristophWurst approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane

lib/IMAP/MessageMapper.php Show resolved Hide resolved
@hamza221 hamza221 force-pushed the deat/filter-mention branch 3 times, most recently from c40ec07 to 70666ce Compare October 14, 2024 18:15
@hamza221
feat: fiter messages by mention
fb946a2 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221 hamza221 merged commit a040882 into main Oct 15, 2024
34 of 35 checks passed
@hamza221 hamza221 deleted the deat/filter-mention branch October 15, 2024 09:46
@hamza221 hamza221 mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny left review comments

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter messages by @mentionsMe
3 participants
@hamza221 @ChristophWurst @st3iny