Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mobile view by using horizontal-split mobile layout #3046

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

devlinjunker
Copy link
Contributor

Summary

Uses new mobileLayout prop of NcAppContent from nextcloud-libraries/nextcloud-vue#6364 and sets to horizontal-split
Adds Navigation Arrows to top of FeedItemDisplay to go to next/previous item when in mobile view

Depends on nextcloud-libraries/nextcloud-vue#6364

Checklist

@wofferl
Copy link
Collaborator

wofferl commented Jan 11, 2025

It looks good so far, there are a few incorrect formatting npm run lint notes.

@devlinjunker devlinjunker requested a review from wofferl January 11, 2025 18:10
Copy link
Collaborator

@wofferl wofferl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to submit the review :)
Please look at the suggestion.

src/components/feed-display/FeedItemDisplay.vue Outdated Show resolved Hide resolved
src/components/feed-display/FeedItemDisplay.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants