Fix note caption colour for custom themes #1460
Conversation
|
@looowizz Can you please share before and after images? Not just for the custom theme, but for the normal styling as well. |
|
Sorry, probably should've included this initially. I think the change gives users more freedom to choose a wider range colours for their primary colour, and I think it just makes more sense as the main text colour is also used in all other Nextcloud header text. Custom themeBeforeAfter
Default themeBefore
After
|
There was a problem hiding this comment.
Thanks, looks good.
Can you pleae amend your commit message to follow the Conventional Commits format, so that the CI test passes?
|
The other failing CI issues should be fixed when #1459 is merged and those changes pulled here |
@enjeck Done! :) |
Custom themes may use colours that do not contrast well with the background for their primary element colour. Removing the line here means the default text colour is used, which I think should be in use here anyway. Signed-off-by: loowiz <[email protected]>
|
@looowizz Thank you! |
juliusknorr
added
bug
Custom themes may use colours that do not contrast well with the background for their primary element colour, e.g. my theme
Removing the line here means the default text colour is used, which I think should be in use here anyway?