feat: reduce search providers per config value "unified_search_providers_allowed"

[printminion-co]

Summary

This feature should help to restrict not desired search providers by allowing only desired search providers.

Before

One can see the /ocs/v2.php/search/providers deliver various search providers (you may see other providers on your nextcloud instance depending on installed/disabled apps).

After feature activation

One can see we allowed only the files and settings search providers (since we do not want to allow any other search providers).

CLI Example: restrict search providers to files and settings

./occ config:system:set unified_search_providers_allowed 0 --value files 
./occ config:system:set unified_search_providers_allowed 1 --value settings

• Resolves: #

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[artonge]

Is the endpoint also not responding when searching in disabled providers?

[artonge]

Suggested change

	private function reduceProviders(array $providers): array {
	private function filterProviders(array $providers): array {

[susnux]

I am not sure, as far as I know we do not have documentation about available search providers. So this config would be blind-guessing.
Maybe it is safer to make it an app config first until we have a occ command to list search providers?

[sorbaugh]

would be blind-guessing. Maybe it is safer to make it an app config first until we have a occ command to list search providers?

@printminion-co would this be ok for you?

[printminion-co]

I am not sure, as far as I know we do not have documentation about available search providers. So this config would be blind-guessing.

I've added more description and screenshots to better describe the feature.
There is no blind-guessing since we allow and not disable the search providers.

Maybe it is safer to make it an app config first until we have a occ command to list search providers?

• We know which providers we want keep enabled.
• We do not need a listing.
• Allowing not existing provider (e.g. foo) will not break the code

cc// @artonge @susnux @sorbaugh

[susnux]

We know which providers we want keep enabled.
We do not need a listing.

For you this might be true, but my fear is that this will confuse other administrators of Nextcloud systems, because of the missing listing / documentation.

There is no blind-guessing since we allow and not disable the search providers.

Well if you know that API endpoint to retrive the available providers yes. What I meant is:
There is no list of available providers in the documentation and no OCC command to query it,
so this would be a feature mostly hidden and undocumented.

That is why I asked if instead of system config also an app config would work? Instead of writing it to the config.php just have it as an core app setting, we could later built an OCC command around it (listing + dis-/enable).

From my side no blocker, but just wanted to bring this up as this might lead to confusion in the future.

[susnux]

We should keep the same format for all related options:

Suggested change

	'unified_search_providers_allowed' => [],
	'unified_search.providers_allowed' => [],

[printminion-co]

Instead of writing it to the config.php just have it as an core app setting, we could later built an OCC command around it (listing + dis-/enable).

I will check this