Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WebP and SVG content types in PhotoCache #48842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Peque
Copy link

@Peque Peque commented Oct 22, 2024

Summary

It seems like CardDAV's PhotoCache is currently only supporting PNG, JPEG, GIF and ICO images.

Nextcloud intercepts GET requests on addressbook URLs ending with ?photo, and uses ALLOWED_CONTENT_TYPES to set the type name, returning 404 if the content type is not supported (not part of the allowed content types struct).

Checklist

@SebastianKrupinski
Copy link
Contributor

@Peque that you for the PR.

I don't see any issues merging this PR other than our CI might not pass due to it coming from a fork. Stay tuned.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing webp images is fine.

However, allowing SVGs is a bit tricky because they pose security risks. They may contain arbitrary JavaScript code, which will be executed when they are rendered inline.

In avatars, they are only rendered using <img> tags which is mostly safe but I would still prefer to not allow them in the photo cache.


And yeah, we probably need to create another PR in the org to fix CI.

Signed-off-by: Miguel Sánchez de León Peque <[email protected]>
@Peque
Copy link
Author

Peque commented Oct 22, 2024

@st3iny I understand your concern. I removed SVG support from the MR so that, at least, WebP is supported (also updated the commit subject accordingly). 😊

@Peque Peque requested a review from st3iny October 22, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image not shown when using WebP instead of JPEG
3 participants