fix(apps-store): Remove apps from force-enabled state when uninstalled #48855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
icewind1991,
Fenn-CS,
sorbaugh and
artonge
and removed request for
a team
If an app is force-enabled and then uninstalled the force-enabled state was kept. This is now removed, so when the app should be re-installed the compatibility should be reevaluated. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/app-store-remove-force-enable
branch
from
d7fcbc2
to
cb45a3b
Compare
susnux
requested review from
provokateurin and
come-nc
and removed request for
icewind1991 and
sorbaugh
| public function ignoreNextcloudRequirementForApp(string $appId): void { | ||
| public function ignoreNextcloudRequirementForApp(string $appId, bool $enabled = true): void { |
There was a problem hiding this comment.
This parameter in conjunction with the method name is a bit ugly.
Would it be possible to have this logic in a separate method instead?
There was a problem hiding this comment.
How would you name the method? unignore...?
There was a problem hiding this comment.
or removeIgnore..., but your suggestion is also fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If an app is force-enabled and then uninstalled the force-enabled state was kept. This is now removed, so when the app should be re-installed the compatibility should be reevaluated.
Checklist