Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(apps): Declare strict types where missing #48859

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

provokateurin
Copy link
Member

Summary

Done with rector. The CI is going to fail, as not everything is working correctly yet.

Feel free to contribute a few fixes to resolve these problems. (if they are part of the app logic please make a separate PR and backport it, if it is just tests then you can push them on this branch)

@miaulalala already did a bunch of fixes to the dav app at the conf. Quite often it is actually the tests that provide wrong data while the application logic is just fine.

Checklist

@nickvergessen
Copy link
Member

  • I am against a mass-change like this 🙈
    As I had to experience myself it can have hidden issues that are not straight forward to debug with "random" side-effects fix(versions): Fix strict trimming of version paths files_accesscontrol#595
  • There will be cases that are not covered by tests or integration tests and it will be a huge pain to discover and draw it back to this. Especially in the file related handling.

@provokateurin
Copy link
Member Author

Makes sense, would you be fine if I limit it to apps with very high test coverage?
It's still useful to test it once, even if we don't enable it in the end, as it will point us to problems we can fix either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress 3. to review Waiting for reviews technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants