changes to enable unified push notifications in generic build. Signed… #4169
Conversation
| @@ -303,6 +303,9 @@ dependencies { | |||
| implementation 'com.github.nextcloud.android-common:ui:0.23.0' | |||
| implementation 'com.github.nextcloud-deps:android-talk-webrtc:121.6167.0' | |||
|
|
|||
| // unified push library for generic flavour | |||
| genericImplementation 'org.codeberg.UnifiedPush:android-connector:2.4.0' | |||
There was a problem hiding this comment.
| genericImplementation 'org.codeberg.UnifiedPush:android-connector:2.4.0' | |
| genericImplementation 'org.unifiedpush.android:connector:2.5.0' |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: github-actions <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Replace Popup bubble with Material Button
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Nextcloud bot <[email protected]>
…v6.0.28 Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…spotbugs.snom-spotbugs-gradle-plugin-6.x Update dependency com.github.spotbugs.snom:spotbugs-gradle-plugin to v6.0.28
….tools.build-gradle-8.x Update dependency com.android.tools.build:gradle to v8.8.0
…v6.1.0 Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
$s -> $d Signed-off-by: Marcel Hibbe <[email protected]>
…llsDelete fix translation for polls_option_delete
Signed-off-by: Nextcloud bot <[email protected]>
- Also converted dialog fragment to compose Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Added string res Fixed bug with embedded date picker boundaries, animated size change Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
…licatedMessagesAfterSend avoid duplicated messages after sending
…-off-by: Gavin Element <[email protected]>
…ion background job to execute
…ions' into unified_push_nextcloud_notifications # Conflicts: # app/src/main/java/com/nextcloud/talk/diagnose/DiagnoseActivity.kt # app/src/main/res/values/strings.xml
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Team mentions
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ql-action-3.x chore(deps): update github/codeql-action action to v3.28.9
|
@gavine99 you may want checkout the DCO error message, if you click on "details" it will explain what you need to do |
userManager.currentUser was called too often. I was not able to prove that a bug is related to it but i think it may fix some hidden bugs. CurrentUserProviderImpl is now used throughout the code to access the current user. userManager.currentUser is only used from CurrentUserProviderImpl whenever the _currentUser was null (should only happen on app startup) To avoid multiple initialization of CurrentUserProviderImpl it was changed to be a @singleton The handling should soon be replaced with coroutine flows. However for the v21.0.0 release it's still done with RxJava to avoid bugs. Signed-off-by: Marcel Hibbe <[email protected]>
…yByCurrentUserprovider replace userManager.currentUser usage by currentUserProvider usage
…-off-by: Gavin Element <[email protected]> Signed-off-by: gavine99 <[email protected]>
…ion background job to execute Signed-off-by: gavine99 <[email protected]>
Signed-off-by: gavine99 <[email protected]>
…-off-by: Gavin Element <[email protected]>
…ions' into unified_push_nextcloud_notifications. Signed-off-by: Gavin Element <[email protected]>
|
@Fuseteam i'm not sure what i'm supposed to do to fix ?? dco results say 8 commits not signed off my 4 commit messages all have sign-off string; the other 4 commits listed dco results are nextcloud android bot and i can't sign them off;
|
|
@gavine99 then i think you need to drop the commits that are not yours, i assume those should be in the main tree already |
changes to allow a UnifiedPush distributor to deliver push messages in generic/f-droid build.
added a setting item to reset push notification registrations in case of issues with push (UnifiedPush distributor can sometimes get out of sync). this same setting item can also be used to reset firebase push in case of issues with it too.
a similar pr has been submitted for the nextcloud android client app - nextcloud/android#13516
this pr is related to, but not dependent on, 3 other pr's;
nextcloud server - nextcloud/server#47763 (to provide enhanced ability for multiple notification handlers)
nextcloud notifications app - nextcloud/notifications#2027 (to provide enhanced ability for multiple notification handlers)
3rd party unified push app - https://codeberg.org/NextPush/uppush/pulls/17 (to allow existing 3rd party nextcloud unifiedpush app to send nextcloud notifications via unifedpush)
altogether, the prs above provide an end-to-end solution for nextcloud to deliver push notifications via UnifiedPush.