Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect dark theme detection caused by missing css load waiting #254

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 3, 2023

☑️ Resolves

Sometimes with a dark theme, some components act like a light theme.

The problem appears when Talk app initializes and starts faster than CSS with the user's theme is loaded.
(Currently, Talk detect dark theme by CSS)

loadCss util is supposed to be async and return a promise, but actually, it doesn't.

This could be not the only problem with dark theme detection thus it also appears out of initial loading.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Create and return promise in loadCss util

@ShGKme ShGKme added bug Something isn't working 3. to review labels Jul 3, 2023
@ShGKme ShGKme added this to the Next Preview milestone Jul 3, 2023
@ShGKme ShGKme self-assigned this Jul 3, 2023
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package seems to work proper, and an error with named import dissapeared, but npm start goes into infinite loading for me

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 3, 2023

Package seems to work proper, and an error with named import dissapeared, but npm start goes into infinite loading for me

Any errors in the console?

@nickvergessen
Copy link
Member

Right same here
grafik Bildschirmfoto vom 2023-07-04 09-07-57

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 24, 2023

Ready to review again after fixing the mentioned issue.

@ShGKme ShGKme merged commit 02c9cd1 into main Jul 24, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/css-loading branch July 24, 2023 14:17
@ShGKme ShGKme mentioned this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants