Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Vue Devtools instead of using electron-devtools-installer #288

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 8, 2023

☑️ Resolves

🚧 Tasks

  • Remove electron-devtools-installer
  • Download vue-devtools chromium extension and add to the repo
  • Embed vue-devtools

@ShGKme ShGKme added this to the Next Preview milestone Aug 8, 2023
@ShGKme ShGKme requested a review from Antreesy August 8, 2023 12:17
@ShGKme ShGKme self-assigned this Aug 8, 2023
@ShGKme ShGKme linked an issue Aug 8, 2023 that may be closed by this pull request
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works again with npm start!

@ShGKme ShGKme merged commit 88dd453 into main Aug 8, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/287/vue-devtools branch August 8, 2023 13:37
@nextcloud nextcloud deleted a comment from github-actions bot Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove electron-devtools-installer, embed vue-devtools another way
2 participants