Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(talk): set --header-height #761

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix(talk): set --header-height #761

merged 1 commit into from
Aug 22, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 20, 2024 •
edited
Loading

☑️ Resolves

  • The header was still visually 50px even its content and system title bar is 50px. It should be 46px.
    • On screenshots see 4px gap under the minimize button
  • By mistake I set height in initLocalStyles which is not used after another PR made that time

🖼️ Screenshots

🏚️ Before 🏡 After
image image

@ShGKme ShGKme added bug Something isn't working 3. to review labels Aug 20, 2024
@ShGKme ShGKme requested a review from Antreesy August 20, 2024 17:03
@ShGKme ShGKme self-assigned this Aug 20, 2024
Antreesy
Antreesy approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't test on Linux

Do we need to export a function, if it's used in the same file? I don't see it can be needed somewhere else

@ShGKme
fix(talk): set --header-height
c662032 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 22, 2024

Do we need to export a function, if it's used in the same file? I don't see it can be needed somewhere else

Removed export

@ShGKme ShGKme enabled auto-merge August 22, 2024 09:04
@ShGKme ShGKme merged commit 2fd5290 into main Aug 22, 2024
7 checks passed
@ShGKme ShGKme deleted the fix/--header-height branch August 22, 2024 09:31
@ShGKme ShGKme mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @Antreesy