Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle download links #840

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: handle download links #840

wants to merge 2 commits into from
+23 −3

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 23, 2024

☑️ Resolves

Unfortunately, there is no better way to handle download links. Electron doesn't handle it, doesn't trigger will-download nor allows detecting that the link was a download link in will-navigate

🖼️ Screenshots

image

@ShGKme ShGKme added enhancement New feature or request 3. to review labels Oct 23, 2024
@ShGKme ShGKme self-assigned this Oct 23, 2024
Antreesy
Antreesy approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

If download attr doesn't specify file extension, it's not considered for file name suggestion:
image

UPD: same for specified .json extension:
image

Something to fix in Talk only?

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 23, 2024

If download attr doesn't specify file extension, it's not considered for file name suggestion:

Is there an example where we have it?

Poll export is .json

image

And for me it works fine in both cases:

  • download value is without extension
  • file url is without extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review enhancement New feature or request
Projects
💬 Talk team
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Direct File Download in Nextcloud Talk on Desktop
2 participants
@ShGKme @Antreesy