Optionally disable ssl checks in all client requests #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
|
Isn't it feasible to just import the self signed ca into the certificate chain? That way you could still validate the certificate |
|
Similar to what we do in integration_openproject. import the certs in development environment to be able to use self-signed certs. |
|
Sure it's possible to import a cert in NC or to add it to the system certs. I thought it could be convenient to quickly and temporarily disable this check for people who want to quickly setup a test environment. @juliusknorr So you think this PR is not necessary and we should close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #988
Can be useful when using self signed certs for the IdP.