-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark mode #45
base: main
Are you sure you want to change the base?
Add dark mode #45
Conversation
@jacobhq is attempting to deploy a commit to the leerob-site Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to revert the lockfile changes as well 🙏
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I don't know what has happened with the lock file diff, it says I added zod to the lockfile, whereas that also exists in main. |
Are you still wanting to continue with this PR? The dashboard still does not work with dark mode. Lmk 🙏 |
I still see this on my machine: #45 (comment) |
Try this on your machine - I noticed some weirdness with screen sizes. I tried simulating a 24" iMac in devtools, but it did not seem to affect styles. To remove the variable of differing machines, please could you take a look at this depolyment: https://next-saas-starter-git-1bb03f-jacob-marshalls-projects-01797007.vercel.app/dashboard/activity?_vercel_share=Ml10bUdPcxqhEGGD5FlkfsfykEz6AV74? You should be able to comment/highlight etc. on there with Vercel Toolbar. |
// Get the theme toggle button // Check and apply saved theme preference from localStorage // Toggle theme on button click // Apply the new theme // Save the theme preference to localStorage |
Adds dark mode to all marketing and dashboard pages. Closes #44.