Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fairmat 2024: mention NXcoordinate_system in NXtransformations #1415

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

lukaspie
Copy link
Contributor

@lukaspie lukaspie commented Sep 23, 2024

Changes:

  • in NXtransformation AXISNAME depends_on, one can place either ".", or the path to an NX_coordinate_system

Explanation of using NXcoordinate_system and NXtransformation:

  • NX_coordinate_system_set contains one or more of NXcoordinate_system
  • in NXcoordinate_system, there is a depends_on, and (NXtransformation) group
  • if a depends_on attribute or field links to a NXcoordinate_system, it should pick the respective depends_on field in that class, and apply the specified TRANSFORMATIONS

Example of how this is implemented in a (proposed) application definition: NXXps

@lukaspie lukaspie marked this pull request as draft September 23, 2024 16:07
@lukaspie lukaspie force-pushed the fairmat-2024-nxtransformations branch from d5b73b5 to 677b6a1 Compare September 23, 2024 16:19
@lukaspie lukaspie marked this pull request as ready for review September 23, 2024 16:19
@sanbrock sanbrock mentioned this pull request Sep 29, 2024
@lukaspie lukaspie linked an issue Sep 29, 2024 that may be closed by this pull request
@lukaspie lukaspie mentioned this pull request Oct 8, 2024
@lukaspie lukaspie force-pushed the fairmat-2024-nxtransformations branch 2 times, most recently from 52e7bac to 7f010d8 Compare October 17, 2024 14:15
domna and others added 10 commits October 17, 2024 16:15
* Updates NXtransformations docs

* Manually set to lower case true

* Do a forward-backward nyaml cycle for NXtransformations
# Conflicts:
#	base_classes/nyaml/NXtransformations.yaml
# Conflicts:
#	base_classes/nyaml/NXtransformations.yaml
# Conflicts:
#	base_classes/nyaml/NXtransformations.yaml
# Conflicts:
#	base_classes/NXtransformations.nxdl.xml
#	base_classes/nyaml/NXtransformations.yaml
# Conflicts:
#	base_classes/nyaml/NXtransformations.yaml
@lukaspie lukaspie added NIAC vote needed PR needs an approving vote from NIAC before merge discussion needed labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed NIAC vote needed PR needs an approving vote from NIAC before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NXtransformations
2 participants