Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Multiplesequencealign CRG specific config #833

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

luisas
Copy link
Contributor

@luisas luisas commented Jan 24, 2025


name: New Multiplesequencealign Config for CRG
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we call the profile crg it will colide with the general CRG config . We should find a specific name for this one, maybe crg_msa?
Or we copy the same specifications to this profile, but this will be more difficult to maintain.

Otherwise LGTM :)

@luisas
Copy link
Contributor Author

luisas commented Jan 24, 2025

I think if we call the profile crg it will colide with the general CRG config . We should find a specific name for this one, maybe crg_msa? Or we copy the same specifications to this profile, but this will be more difficult to maintain.

Otherwise LGTM :)

i think in other cases they also do not change the name, like here

https://github.com/nf-core/configs/blob/master/pipeline/proteinfold.config

do u think I can leave it? I like it better so that i do not have to remember this extra config name too

@mirpedrol
Copy link
Member

Oh ok, then it doesn't override it. I see @JoseEspinosa did the proteinfold one, so if he says it's ok like this I am happy with it 🙂

@luisas
Copy link
Contributor Author

luisas commented Jan 24, 2025

Fantastic, thanks!!

@luisas luisas merged commit 408642a into nf-core:master Jan 24, 2025
140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants