Skip to content

Commit

Permalink
Remove Wave Dockerfile Singularity builds (#7042)
Browse files Browse the repository at this point in the history
* chore: Move scripts to scripts

* fix: Add rich_click as a dependency

Not all of us have it installed to our system Python environment @ewels ;)

* ci: Remove Dockerfile and wave builds

Per Paolo, you need a singularity file to build a Singularity image not
a Dockerfile
  • Loading branch information
edmundmiller authored Nov 20, 2024
1 parent a0e49eb commit 3ceae3a
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 5 deletions.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
1 change: 1 addition & 0 deletions .github/scripts/wave_singularity.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# dependencies = [
# "requests",
# "rich",
# "rich_click"
# ]
# ///

Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/wave.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,14 @@ jobs:
# if: github.repository == 'nf-core/modules'
if: ${{ needs.generate-matrix.outputs.docker-matrix != '[]' }}
needs: generate-matrix
name: Build Dockerfile-based ${{ matrix.profile }} Container
name: Build Dockerfile-based Container
runs-on: ubuntu-latest
timeout-minutes: 60
strategy:
fail-fast: false
max-parallel: 4
matrix:
files: "${{ fromJson(needs.generate-matrix.outputs.docker-matrix) }}"
profile: [docker, singularity]
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4

Expand All @@ -117,11 +116,8 @@ jobs:
- name: Build ${{ matrix.profile }} container
# NOTE If you're changing a Dockerfile and this is running, try to update the Dockerfile to build with wave
continue-on-error: false
env:
PROFILE: ${{ (contains(matrix.profile, 'singularity') && '--singularity') || '' }}
run: |
wave -f "${{ matrix.files }}" \
$PROFILE \
--freeze \
--await \
--build-repo quay.io/nf-core/modules/${{steps.registry-name.outputs.result}} \
Expand Down

0 comments on commit 3ceae3a

Please sign in to comment.