Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "add paths in output directive in cellranger cout module" #5306

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Revert "add paths in output directive in cellranger cout module" #5306

merged 1 commit into from
Mar 20, 2024

Conversation

fmalmeida
Copy link
Contributor

Reverts #5108

@fmalmeida fmalmeida self-assigned this Mar 20, 2024
@fmalmeida
Copy link
Contributor Author

Hi @pinin4fjords ,
Opening PR reversion as requested.

@fmalmeida fmalmeida added this pull request to the merge queue Mar 20, 2024
Merged via the queue into master with commit 1774f78 Mar 20, 2024
10 checks passed
vlebars pushed a commit to vlebars/modules that referenced this pull request Mar 20, 2024
@fmalmeida
Revert "add paths in output directive in cellranger cout module" (nf-…
714f665 
…core#5306)

Revert "add paths in output directive in cellranger cout module (nf-core#5108)"

This reverts commit 92ca535.
jvfe added a commit to jvfe/modules that referenced this pull request Mar 20, 2024
@jvfe
Merge branch 'master' into nf-test_islandpath
2be1844 
* master:
  Added contrast limited adaptive histogram equalization module (nf-core#5268)
  Leviosam2 index (nf-core#5316)
  Add subworkflow mapAD (nf-core#5239)
  Remove AMRFinderPlus DB update on each invocation (nf-core#5232)
  Revert "add paths in output directive in cellranger cout module" (nf-core#5306)
  Revert "update kallistobustools count output list" (nf-core#5307)
  Igv reports (nf-core#5263)
  Remove unnecessary .view() in subworkflows/nf-core/vcf_phase_shapeit5 & tests/modules/nf-core/shapeit5/ligate/main.nf (nf-core#5280)
  Add wittyer as module (nf-core#5171)
  Bamstats (nf-core#4474)
  gatk4_asereadcounter add updated meta and nf-tests (nf-core#5164)
  4557 new module kaijumergeoutputs + stub Kraken2/Kraken2 (nf-core#5249)
  add cram/index support to bwamem2 (nf-core#5248)
  Add README to modules build with Docker (nf-core#4935)
  update paths for VEP (nf-core#5281)
  nf-test bases2fastq (nf-core#5272)
  Add module seqfu/stats (nf-core#5275)
jvfe added a commit to jvfe/modules that referenced this pull request Mar 20, 2024
@jvfe
Merge branch 'master' into nf-test_phispy
294a9c0 
* master:
  Added contrast limited adaptive histogram equalization module (nf-core#5268)
  Leviosam2 index (nf-core#5316)
  Add subworkflow mapAD (nf-core#5239)
  Remove AMRFinderPlus DB update on each invocation (nf-core#5232)
  Revert "add paths in output directive in cellranger cout module" (nf-core#5306)
  Revert "update kallistobustools count output list" (nf-core#5307)
  Igv reports (nf-core#5263)
  Remove unnecessary .view() in subworkflows/nf-core/vcf_phase_shapeit5 & tests/modules/nf-core/shapeit5/ligate/main.nf (nf-core#5280)
  Add wittyer as module (nf-core#5171)
  Bamstats (nf-core#4474)
  gatk4_asereadcounter add updated meta and nf-tests (nf-core#5164)
  4557 new module kaijumergeoutputs + stub Kraken2/Kraken2 (nf-core#5249)
  add cram/index support to bwamem2 (nf-core#5248)
  Add README to modules build with Docker (nf-core#4935)
  update paths for VEP (nf-core#5281)
  nf-test bases2fastq (nf-core#5272)
  Add module seqfu/stats (nf-core#5275)
  Added gt/gff3validator (nf-core#4718)
  Added liftoff (nf-core#5209)
tucano pushed a commit to tucano/modules that referenced this pull request Mar 20, 2024
@fmalmeida @tucano
Revert "add paths in output directive in cellranger cout module" (nf-…
01b3529 
…core#5306)

Revert "add paths in output directive in cellranger cout module (nf-core#5108)"

This reverts commit 92ca535.
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@fmalmeida @jennylsmith
Revert "add paths in output directive in cellranger cout module" (nf-…
33a8f39 
…core#5306)

Revert "add paths in output directive in cellranger cout module (nf-core#5108)"

This reverts commit 92ca535.
alexnater pushed a commit to alexnater/nf-core-modules that referenced this pull request Mar 21, 2024
@fmalmeida
Revert "add paths in output directive in cellranger cout module" (nf-…
fb889a1 
…core#5306)

Revert "add paths in output directive in cellranger cout module (nf-core#5108)"

This reverts commit 92ca535.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

@ggabernet ggabernet Awaiting requested review from ggabernet

@edmundmiller edmundmiller Awaiting requested review from edmundmiller

Assignees

@fmalmeida fmalmeida

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmalmeida @pinin4fjords