Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seqkit to version 2.9.0 #7315

Merged
merged 11 commits into from
Jan 17, 2025
Merged

Conversation

heuermh
Copy link
Contributor

@heuermh heuermh commented Jan 15, 2025

Second part of #7314

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@heuermh
Copy link
Contributor Author

heuermh commented Jan 15, 2025

Why is nf-test running (and failing) against modules not touched by this pull request?

@SPPearce
Copy link
Contributor

Why is nf-test running (and failing) against modules not touched by this pull request?

Generally either because they use SEQKIT modules to setup their tests, or they are subworkflows that use SEQKIT.
In this case, you have two subworkflows, FASTA_EXPLORE_SEARCH_PLOT_TIDK and FASTQ_FIND_MIRNA_MIRDEEP2 that will need their snapshots updating, as their versions.yml have now changed.

@heuermh
Copy link
Contributor Author

heuermh commented Jan 16, 2025

FASTQ_FIND_MIRNA_MIRDEEP2 doesn't run for me locally

$ nf-test test subworkflows/nf-core/fastq_find_mirna_mirdeep2/tests/main.nf.test --profile docker
...
    Status: Downloaded newer image for quay.io/biocontainers/mirdeep2:2.0.1.2--0
    qemu: uncaught target signal 11 (Segmentation fault) - core dumped
    .command.sh: line 7:    76 Segmentation fault      mapper.pl small_Clone1_N1.fasta -c -j
-k TCGTATGCCGTCTTCTGCTTGT -l 18 -m -v -p bowtie/genome -s small_Clone1_N1_collapsed.fa
-t small_Clone1_N1_reads_collapsed_vs_genome_genome.arf

Is it safe to just manually update version checksums in the snap file?

@SPPearce
Copy link
Contributor

Yeah, if it runs on the CI that's sufficient

@SPPearce SPPearce added this pull request to the merge queue Jan 17, 2025
Merged via the queue into nf-core:master with commit 60645c2 Jan 17, 2025
41 checks passed
@heuermh
Copy link
Contributor Author

heuermh commented Jan 17, 2025

Thank you, @SPPearce!

@heuermh heuermh deleted the seqkit-2.9.0-part-2 branch January 17, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants