Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lots of yaml formatting errors #7399

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Fix lots of yaml formatting errors #7399

merged 3 commits into from
Jan 31, 2025

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 30, 2025

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jfy133 jfy133 marked this pull request as ready for review January 30, 2025 16:21
@mashehu
Copy link
Contributor

mashehu commented Jan 31, 2025

failing lint test for doubletdetection is a bug in nf-core/tools nf-core/tools#3436 will merge this PR with this failing test.

@mashehu mashehu merged commit 5a32b2d into master Jan 31, 2025
95 of 97 checks passed
@mashehu mashehu deleted the fix-linting-errrors branch January 31, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants