Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[linting] fix linting for differential_functional_enrichment subworkflow #7407

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[linting] fix linting for differential_functional_enrichment subworkflow #7407

merged 1 commit into from
Jan 31, 2025

Conversation

suzannejin
Copy link
Contributor

@suzannejin suzannejin commented Jan 31, 2025 •
edited
Loading

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@suzannejin suzannejin added this pull request to the merge queue Jan 31, 2025
Merged via the queue into master with commit a19feab Jan 31, 2025
30 checks passed
@suzannejin suzannejin deleted the fix_linting_errors_diff branch January 31, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@pinin4fjords pinin4fjords Awaiting requested review from pinin4fjords

@jfy133 jfy133 Awaiting requested review from jfy133

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suzannejin @mashehu