Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced nfdi4pso terms in next generation sequencing template #104

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

StellaEggels
Copy link
Collaborator

No description provided.

@StellaEggels StellaEggels requested a review from Brilator February 7, 2024 09:21
@StellaEggels
Copy link
Collaborator Author

#105 @Freymaurer added accession numbers to the ambiguous tags and changed similar tags to be identical. (I couldn't figure out how to open a separate pull request with one already open, so it is combined with the previous one.)

@Freymaurer
Copy link
Collaborator

Freymaurer commented Feb 13, 2024

#105 @Freymaurer added accession numbers to the ambiguous tags and changed similar tags to be identical. (I couldn't figure out how to open a separate pull request with one already open, so it is combined with the previous one.)

Thanks alot @StellaEggels ! Did you, by any chance, also resolve issue #106 ? If yes we could close both and i could add an additional quality control pipeline step tomorrow #107

@StellaEggels
Copy link
Collaborator Author

I didn’t resolve issue #106 yet, because I was unsure about two things: 1. If in the Excel version the ER tags aren’t currently shown in the search, but only the "normal" tags, should they really be deleted from the normal tags yet? And 2. If the templates are not really “repository templates”, should we really add a repository as ER tag? If yes, I can quickly do that tomorrow so you can add the pipeline step.

@Freymaurer
Copy link
Collaborator

I didn’t resolve issue #106 yet, because I was unsure about two things: 1. If in the Excel version the ER tags aren’t currently shown in the search, but only the "normal" tags, should they really be deleted from the normal tags yet? And 2. If the templates are not really “repository templates”, should we really add a repository as ER tag? If yes, I can quickly do that tomorrow so you can add the pipeline step.

Maybe @Brilator can give more insight regarding this topic ☺️

@StellaEggels StellaEggels merged commit 779163b into nfdi4plants:main Feb 14, 2024
1 check passed
@Brilator
Copy link
Member

Sorry for being late to the party.

  1. If the templates are not really “repository templates”, should we really add a repository as ER tag? If yes, I can quickly do that tomorrow so you can add the pipeline step.

Some ER tags are still a left-over from when we wanted to design templates in a modular fashion: you would combine multiple templates (e.g. growth, extraction, assay) to submit to one ER. In this case growth could be microbes or plants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants