fix(Dialog): conditionally render title prop

nginformatica · Jul 4, 2023 · 7ce0b09 · 7ce0b09
1 parent 6b0c15d
commit 7ce0b09
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "flipper-ui",
-  "version": "0.29.4",
+  "version": "0.29.5",
   "description": "",
   "main": "dist/index.js",
   "homepage": "https://flipper-ui.ngi.com.br/",

diff --git a/src/core/feedback/dialog/dialog.spec.tsx b/src/core/feedback/dialog/dialog.spec.tsx
@@ -94,6 +94,7 @@ describe('Dialog', () => {
         render(
             <Dialog
                 open
+                aria-title='dialog-paper'
                 title='My beautiful Dialog'
                 text={'Is not it?'}
                 onClose={jest.fn()}
@@ -114,6 +115,7 @@ describe('Dialog', () => {
         render(
             <Dialog
                 open
+                aria-title='dialog-paper'
                 title='My beautiful Dialog'
                 text={'Is not it?'}
                 onClose={jest.fn()}
@@ -134,6 +136,7 @@ describe('Dialog', () => {
         render(
             <Dialog
                 open
+                aria-title='dialog-paper'
                 title='My beautiful Dialog'
                 text={'Is not it?'}
                 onClose={jest.fn()}
@@ -154,6 +157,7 @@ describe('Dialog', () => {
         render(
             <Dialog
                 open
+                aria-title='dialog-paper'
                 title='My beautiful Dialog'
                 text={'Is not it?'}
                 onClose={jest.fn()}

diff --git a/src/core/feedback/dialog/index.tsx b/src/core/feedback/dialog/index.tsx
@@ -32,6 +32,7 @@ export interface DialogProps
     snippetContentStyle?: CSSProperties
     contentTextStyle?: CSSProperties
     scroll?: 'body' | 'paper' | 'unset-paper' | 'unset-body'
+    'aria-title'?: string
     onClose?: (event: Event) => void
 }
 
@@ -86,6 +87,7 @@ export const Dialog = ({
     title,
     snippetStyle,
     snippetContentStyle,
+    'aria-title': ariaTitle,
     ...otherProps
 }: DialogProps) => {
     const classes = useStyles()
@@ -176,7 +178,7 @@ export const Dialog = ({
             maxWidth={maxWidth}
             scroll={scrollMode}
             PaperProps={{
-                title: 'dialog-paper',
+                ...(ariaTitle ? { title: ariaTitle } : {}),
                 classes:
                     scroll === 'unset-body' || scroll === 'unset-paper'
                         ? { root: classes.root }