Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watch network connect / disconnect events #610

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented May 14, 2024

This PR make use of the new Docker API event format available on Docker API v1.22+ (the old event format is automatically translated to the new one by fsouza/go-dockerclient) and make docker-gen watch for network connect and disconnect events.

Close #190

Ping @outdooracorn

@buchdag buchdag self-assigned this May 14, 2024
@buchdag buchdag marked this pull request as ready for review May 14, 2024 08:19
@buchdag buchdag changed the title feat: watch network connect / disconnect event feat: watch network connect / disconnect events May 14, 2024
@outdooracorn
Copy link

Thanks for creating this PR 🙌
I use docker-gen as part of the nginx-proxy container. What would be the best way to test this PR? Build the binary locally and then docker cp it into the container?

@buchdag
Copy link
Member Author

buchdag commented May 16, 2024

I've pushed a custom built nginx-proxy image for you to test: docker pull nginxproxy/nginx-proxy:network-event

@buchdag
Copy link
Member Author

buchdag commented May 22, 2024

@outdooracorn any luck trying nginxproxy/nginx-proxy:network-event ? Let me know if you need any help.

@buchdag
Copy link
Member Author

buchdag commented Jul 18, 2024

Ping @outdooracorn 👋

@buchdag buchdag force-pushed the watch-network-event branch from 91ddfac to b6b6a26 Compare October 6, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listen for network (dis)connect events (API v1.22+)
2 participants