Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrade documentation #526

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Update upgrade documentation #526

merged 5 commits into from
Dec 11, 2023

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Dec 6, 2023

Proposed changes

Update upgrade documentation based on the change in behaviour introduced by this PR #352

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 7806941
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6576f9ac77f87c0008b4ae2e
😎 Deploy Preview https://deploy-preview-526--agent-public-docs.netlify.app/nginx-agent/upgrading
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 6, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63943e9) 66.14% compared to head (093f6b6) 66.15%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
+ Coverage   66.14%   66.15%   +0.01%     
==========================================
  Files         118      118              
  Lines       13468    13468              
==========================================
+ Hits         8908     8910       +2     
+ Misses       3959     3957       -2     
  Partials      601      601              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jcahilltorre Jcahilltorre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments

@dhurley dhurley merged commit 8e4392d into main Dec 11, 2023
27 checks passed
@dhurley dhurley deleted the update-upgrade-docs branch December 11, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants