Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poc/waf v4.x #5572

Closed
wants to merge 21 commits into from
Closed

Poc/waf v4.x #5572

wants to merge 21 commits into from

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented May 17, 2024

Proposed changes

Changes:

  1. Updates to Dockerfile to pull from the pkgs-test repo. Changes taken configurable plus repo #5013 for testing

Example build command:

make debian-image-plus TARGET=local TAG=r32-test PREFIX=nginx-plus-ingress PLUS_REPO=pkgs-test.nginx.com

What's working:

  • Build NIC with the latest v4 version of NAP (set NGINX_PLUS_VERSION=R31 in Dockerfile first)

What's not working

  • Build v4 NAP with R32 of NIC from the preview repo.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added docker Pull requests that update Docker code chore Pull requests for routine tasks labels May 17, 2024
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label May 24, 2024
@github-actions github-actions bot removed github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels May 29, 2024
@shaun-nx
Copy link
Contributor Author

Closing as changes were added in #5649

@shaun-nx shaun-nx closed this May 30, 2024
@shaun-nx shaun-nx deleted the poc/waf-v4.x branch July 31, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant